-
Notifications
You must be signed in to change notification settings - Fork 165
Spdx 3.0 Parser for SBOM files #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nt compliance standards
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
==========================================
+ Coverage 46.50% 46.77% +0.27%
==========================================
Files 355 361 +6
Lines 14142 14274 +132
Branches 1161 1175 +14
==========================================
+ Hits 6577 6677 +100
- Misses 7017 7042 +25
- Partials 548 555 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super familiar with this effort so feel free to ignore me if any of my comments are way off base :)
src/Microsoft.Sbom.Common/JsonAsynchronousNodeKit/LargeJsonParser.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Sbom.Parsers.Spdx30SbomParser/Entities/Enums/RelationshipType.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just 2 more comments that you can take or leave
src/Microsoft.Sbom.Parsers.Spdx30SbomParser/Parser/SPDX30Parser.cs
Outdated
Show resolved
Hide resolved
Hey @pragnya17, great work !! I am really excited to generate SPDX:3.0 SBOMs. Can we generate now ? |
Parsing spdx 3.0 with Unit tests and support for parsing with different compliance standards. More details here: https://dev.azure.com/mseng/1ES/_workitems/edit/2233308