Skip to content

Spdx 3.0 Parser for SBOM files #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Spdx 3.0 Parser for SBOM files #860

merged 7 commits into from
Jan 14, 2025

Conversation

pragnya17
Copy link
Contributor

Parsing spdx 3.0 with Unit tests and support for parsing with different compliance standards. More details here: https://dev.azure.com/mseng/1ES/_workitems/edit/2233308

@pragnya17 pragnya17 requested a review from a team as a code owner January 10, 2025 02:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 76.16279% with 41 lines in your changes missing coverage. Please review.

Project coverage is 46.77%. Comparing base (3d38ef0) to head (c4b0acb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...om.Parsers.Spdx30SbomParser/Parser/SPDX30Parser.cs 82.29% 11 Missing and 6 partials ⚠️
...crosoft.Sbom.Parsers.Spdx30SbomParser/Validator.cs 0.00% 9 Missing ⚠️
...crosoft.Sbom.Parsers.Spdx30SbomParser/Generator.cs 66.66% 5 Missing and 1 partial ⚠️
...sers.Spdx30SbomParser/Entities/NTIASpdxDocument.cs 0.00% 5 Missing ⚠️
....Common/JsonAsynchronousNodeKit/LargeJsonParser.cs 92.30% 0 Missing and 1 partial ⚠️
...Sbom.Parsers.Spdx30SbomParser/Entities/NTIAFile.cs 83.33% 1 Missing ⚠️
....Parsers.Spdx30SbomParser/Parser/ContextsResult.cs 75.00% 1 Missing ⚠️
....Parsers.Spdx30SbomParser/Parser/ElementsResult.cs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
+ Coverage   46.50%   46.77%   +0.27%     
==========================================
  Files         355      361       +6     
  Lines       14142    14274     +132     
  Branches     1161     1175      +14     
==========================================
+ Hits         6577     6677     +100     
- Misses       7017     7042      +25     
- Partials      548      555       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sfoslund sfoslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with this effort so feel free to ignore me if any of my comments are way off base :)

Copy link
Member

@sfoslund sfoslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 2 more comments that you can take or leave

@pragnya17 pragnya17 enabled auto-merge (squash) January 14, 2025 20:49
@pragnya17 pragnya17 merged commit 4cc3135 into main Jan 14, 2025
7 checks passed
@pragnya17 pragnya17 deleted the ppandrate_parseSpdx3.0 branch January 14, 2025 20:50
@viveksahu26
Copy link

Hey @pragnya17, great work !! I am really excited to generate SPDX:3.0 SBOMs. Can we generate now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants